Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implements Signaling Data Flow Controller #3970

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

wolf4ood
Copy link
Contributor

@wolf4ood wolf4ood commented Mar 7, 2024

What this PR changes/adds

Introduces a new module transfer-data-plane-signaling that contains a new DataFlowController
compliant with the data plane signaling spec.

This is additive and does not impact the current DataFlowControllers.

A first E2E test with PUSH scenario was also implemented using the data plane signaling protocol.
For making the test work the transformer for the DataAddress for the client -> api communicantion
where reverted to EDC one.

Why it does that

data plane signaling

Further notes

For having a E2E test with PULL scenario we have to tackle the following topics

Linked Issue(s)

Closes #3901

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@wolf4ood wolf4ood force-pushed the feat/3901_dps_flow_controller branch 3 times, most recently from 6717ee6 to 72294bc Compare March 7, 2024 09:48
@wolf4ood wolf4ood self-assigned this Mar 7, 2024
@wolf4ood wolf4ood added the enhancement New feature or request label Mar 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 95.31250% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 73.39%. Comparing base (7f20ba5) to head (6195da8).
Report is 125 commits behind head on main.

Files Patch % Lines
...taplane/flow/DataPlaneSignalingFlowController.java 98.03% 0 Missing and 1 partial ⚠️
...figuration/SignalingApiConfigurationExtension.java 0.00% 1 Missing ⚠️
...controller/v1/DataPlaneSignalingApiController.java 87.50% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3970      +/-   ##
==========================================
+ Coverage   71.74%   73.39%   +1.64%     
==========================================
  Files         919      965      +46     
  Lines       18457    19448     +991     
  Branches     1037     1098      +61     
==========================================
+ Hits        13242    14273    +1031     
+ Misses       4756     4709      -47     
- Partials      459      466       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wolf4ood wolf4ood force-pushed the feat/3901_dps_flow_controller branch 3 times, most recently from 88e8674 to 6195da8 Compare March 7, 2024 11:50
@wolf4ood wolf4ood marked this pull request as ready for review March 7, 2024 13:10
@wolf4ood wolf4ood force-pushed the feat/3901_dps_flow_controller branch 2 times, most recently from f28f2ba to 7ea0fc4 Compare March 7, 2024 13:35
@wolf4ood wolf4ood force-pushed the feat/3901_dps_flow_controller branch from cda2833 to 4d5f676 Compare March 7, 2024 15:14
@wolf4ood wolf4ood force-pushed the feat/3901_dps_flow_controller branch from 4d5f676 to 73f9963 Compare March 8, 2024 11:04
@wolf4ood wolf4ood merged commit 3b1e083 into eclipse-edc:main Mar 8, 2024
17 checks passed
@wolf4ood wolf4ood deleted the feat/3901_dps_flow_controller branch March 8, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DPS: Implement a new DataFlowController compliant with the signaling protocol
3 participants