Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduces optional JSON-LD context for management API #4470

Merged

Conversation

wolf4ood
Copy link
Contributor

@wolf4ood wolf4ood commented Sep 11, 2024

What this PR changes/adds

introduces optional JSON-LD context for management API

Why it does that

improves JSON-LD objects in management APIs

Further notes

  • Removed management-api-json-ld-context extension
  • management-context-v1.jsonld moved in the json-ld extension
  • @vocab and edc namespace definition are not loaded in the default scope (*) but each scope registers them
  • Excluding the @vocab is still possible with the edc.jsonld.vocab.disable config. If it's disabled the registerNamespace implementation will skip it

To activate the JSON-LD context in the management API set edc.management.context.enabled=true

Since the @vocab and edc prefixes are removed from the default scope but registered in each scope separately,
this is a breaking change only for people that, when extending EDC uses the JsonLd service and do not specify the scope when compacting., or for extensions that use a custom scope but do not register @vocab and edc directly.

Linked Issue(s)

Closes #4466

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@wolf4ood wolf4ood added enhancement New feature or request breaking-change Will require manual intervention for version update labels Sep 11, 2024
@wolf4ood wolf4ood self-assigned this Sep 11, 2024
@wolf4ood wolf4ood force-pushed the feat/4466_bundle_management_context branch 4 times, most recently from c54fb37 to 25f3071 Compare September 12, 2024 10:26
@wolf4ood wolf4ood marked this pull request as ready for review September 12, 2024 14:13
@wolf4ood wolf4ood force-pushed the feat/4466_bundle_management_context branch from 2b2f122 to 9eacd54 Compare September 16, 2024 07:22
@wolf4ood wolf4ood merged commit 7b3c28e into eclipse-edc:main Sep 16, 2024
21 checks passed
@wolf4ood wolf4ood deleted the feat/4466_bundle_management_context branch September 16, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Will require manual intervention for version update enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundle the management API context
3 participants