fix: only return dataset with valid offers #4490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronjaquensel
requested review from
wolf4ood,
jimmarino,
ndr-brt and
paullatzelsperger
ndr-brt
reviewed
Sep 25, 2024
...atalog/src/main/java/org/eclipse/edc/connector/controlplane/catalog/DatasetResolverImpl.java
Show resolved
Hide resolved
ndr-brt
approved these changes
Sep 25, 2024
ndr-brt
pushed a commit
to Think-iT-Labs/edc-connector
that referenced
this pull request
Sep 25, 2024
* fix: only return dataset with valid offers * test: add additional test
ndr-brt
added a commit
that referenced
this pull request
Sep 25, 2024
* fix: only return dataset with valid offers (#4490) * fix: only return dataset with valid offers * test: add additional test * dependencies --------- Co-authored-by: Ronja Quensel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Adds a check to the
DatasetResolverImplto only return a dataset if it has an offer attached.Why it does that
To avoid exposing sensitive information (asset metadata) if the requesting participant is not authorized to see it.
Further notes
Also adds a check for
queryandgetByIdto immediately return if no valid contract definitions exist for the requesting participant, as then no offers would be returned anyway, so it doesn't make sense to query and evaluate the assets in that case.