fix: build failing on Windows (#4484) #4504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change path handling to correctly handle Windows pathnames. Change line ending handling from using `System.lineSeparator` to using the regex \R to treat all unicode line ending character sequences as the line endings. Change unit tests that compared certificates read from file, to ignore the line ending characters, so differences in line ending did not break the test. Refs: eclipse-edc#4484
Barium
requested review from
bscholtes1A,
jimmarino,
paullatzelsperger and
ndr-brt
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
We are always happy to welcome new contributors ❤️ To make things easier for everyone, please make sure to follow our contribution guidelines, check if you have already signed the ECA, and relate this pull request to an existing issue or discussion.
jimmarino
approved these changes
Sep 27, 2024
|
I can see that the PR failed a check since I must have forgotten to add the "Bug" label (thank you for adding it @jimmarino ), do I have to retrigger the checks somehow? |
|
@Barium we need to fix something on our |
paullatzelsperger
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Change path handling to correctly handle Windows path names.
Change line ending handling from using
System.lineSeparatorto using the regex \R to treat all unicode line ending character sequences as the line endings.Change unit tests that compared certificates read from file, to ignore the line ending characters, so differences in line ending did not break the test.
Why it does that
The code failed during the unit tests when build on Windows, this change corrects the issues and enables the code to build. Generally checking for specific line endings (ie.
System.lineSeperator) could be avoided and instead using the\Rto match all unicode line endings will make the code more robust towards being built on different systems.Linked Issue(s)
Closes #4484