Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dspace 2024/1 compliant transformers #4581

Merged

Conversation

wolf4ood
Copy link
Contributor

@wolf4ood wolf4ood commented Oct 24, 2024

What this PR changes/adds

dspace 2024/1 compliant transformers.

Duplicates all the dsp from transformers when needed for:

  • consumerPid and providerPid as @id
  • participantId in catalog as @id
  • assigner and assignee in ContractAgreementMessage as @id
  • state as @id in ContractNegotiation and TransferProcess
  • endpointType in data address as @id
  • format and agreementId in TransferRequestMessage as @id
  • eventType in ContractNegotiationEventMessage as @id
  • state in JsonObjectFromTransferProcessTransformer transformed like the JsonObjectFromContractNegotiationTransformer

Why it does that

dsp 2024/1 compliance

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #4577

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@wolf4ood wolf4ood force-pushed the fix/4577_dsp_2024_compatible_ser branch from fe8c1b2 to 80f6f82 Compare October 24, 2024 15:20
@wolf4ood wolf4ood self-assigned this Oct 24, 2024
@wolf4ood wolf4ood added dataspace-protocol related to the dataspace protocol bug Something isn't working labels Oct 24, 2024
@wolf4ood wolf4ood force-pushed the fix/4577_dsp_2024_compatible_ser branch 3 times, most recently from 1b8f2ab to 2b5b54a Compare October 24, 2024 15:38
@wolf4ood wolf4ood force-pushed the fix/4577_dsp_2024_compatible_ser branch from 2b5b54a to 31f755c Compare October 24, 2024 16:51
@wolf4ood wolf4ood marked this pull request as ready for review October 25, 2024 09:30
@wolf4ood wolf4ood merged commit 55405aa into eclipse-edc:main Oct 28, 2024
27 checks passed
@wolf4ood wolf4ood deleted the fix/4577_dsp_2024_compatible_ser branch October 28, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dataspace-protocol related to the dataspace protocol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dspace 2024/1 compatible serialization
2 participants