-
Notifications
You must be signed in to change notification settings - Fork 355
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Broken pipe Exception from Jersey layer while closing response in Ser…
…verRuntime.writeResponse() not handled or re-thrown #5783 (#5786) Signed-off-by: Jorge Bescos Gascon <[email protected]>
- Loading branch information
Showing
4 changed files
with
121 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
97 changes: 97 additions & 0 deletions
97
tests/e2e-server/src/test/java/org/glassfish/jersey/tests/e2e/server/Issue5783Test.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,97 @@ | ||
| /* | ||
| * Copyright (c) 2024 Oracle and/or its affiliates. All rights reserved. | ||
| * | ||
| * This program and the accompanying materials are made available under the | ||
| * terms of the Eclipse Public License v. 2.0, which is available at | ||
| * http://www.eclipse.org/legal/epl-2.0. | ||
| * | ||
| * This Source Code may also be made available under the following Secondary | ||
| * Licenses when the conditions for such availability set forth in the | ||
| * Eclipse Public License v. 2.0 are satisfied: GNU General Public License, | ||
| * version 2 with the GNU Classpath Exception, which is available at | ||
| * https://www.gnu.org/software/classpath/license.html. | ||
| * | ||
| * SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0 | ||
| */ | ||
|
|
||
| package org.glassfish.jersey.tests.e2e.server; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
|
|
||
| import java.io.ByteArrayOutputStream; | ||
| import java.io.IOException; | ||
| import java.lang.reflect.InvocationHandler; | ||
| import java.lang.reflect.Method; | ||
| import java.lang.reflect.Proxy; | ||
|
|
||
| import javax.ws.rs.GET; | ||
| import javax.ws.rs.Path; | ||
| import javax.ws.rs.container.ContainerRequestContext; | ||
| import javax.ws.rs.container.ContainerResponseContext; | ||
| import javax.ws.rs.container.ContainerResponseFilter; | ||
| import javax.ws.rs.core.Application; | ||
| import javax.ws.rs.core.Context; | ||
| import javax.ws.rs.core.Response; | ||
| import javax.ws.rs.ext.Provider; | ||
|
|
||
| import org.glassfish.jersey.server.ContainerRequest; | ||
| import org.glassfish.jersey.server.ResourceConfig; | ||
| import org.glassfish.jersey.server.spi.ContainerResponseWriter; | ||
| import org.glassfish.jersey.test.JerseyTest; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| public class Issue5783Test extends JerseyTest { | ||
|
|
||
| private static final String ERROR = "Intentional issue5783 exception"; | ||
| private static volatile String exceptionMessage; | ||
|
|
||
| @Override | ||
| protected Application configure() { | ||
| return new ResourceConfig(Resource.class, ResponseFilter.class); | ||
| } | ||
|
|
||
| @Test | ||
| public void closeException() throws InterruptedException { | ||
| target("/test").request().get(); | ||
| assertEquals(ERROR, exceptionMessage); | ||
| } | ||
|
|
||
| @Path("/test") | ||
| public static class Resource { | ||
|
|
||
| @GET | ||
| public Response closeException(@Context ContainerRequest request) { | ||
| // Save the exception when response.getRequestContext().getResponseWriter().failure(e) | ||
| ContainerResponseWriter writer = request.getResponseWriter(); | ||
| ContainerResponseWriter proxy = (ContainerResponseWriter) Proxy.newProxyInstance( | ||
| ContainerResponseWriter.class.getClassLoader(), | ||
| new Class<?>[]{ContainerResponseWriter.class}, new InvocationHandler() { | ||
| @Override | ||
| public Object invoke(Object proxy, Method method, Object[] args) throws Throwable { | ||
| if ("failure".equals(method.getName())) { | ||
| exceptionMessage = ((Throwable) args[0]).getCause().getMessage(); | ||
| } | ||
| return method.invoke(writer, args); | ||
| } | ||
| }); | ||
| request.setWriter(proxy); | ||
| return Response.ok().build(); | ||
| } | ||
| } | ||
|
|
||
| @Provider | ||
| public static class ResponseFilter implements ContainerResponseFilter { | ||
| @Override | ||
| public void filter(ContainerRequestContext requestContext, ContainerResponseContext responseContext) | ||
| throws IOException { | ||
| // Hack it to make ContainerResponse#close throws one exception | ||
| responseContext.setEntity("something"); | ||
| responseContext.setEntityStream(new ByteArrayOutputStream() { | ||
| @Override | ||
| public void close() throws IOException { | ||
| throw new IOException(ERROR); | ||
| } | ||
| }); | ||
| } | ||
| } | ||
| } |