Fix possible concurrent issue with SSL & default connector #5794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansupol
force-pushed
the
connector.concurrent
branch
from
156ce22
to
addb97a
Compare
Signed-off-by: jansupol <[email protected]>
jansupol
force-pushed
the
connector.concurrent
branch
from
addb97a
to
bdb97fc
Compare
dtbaum
reviewed
Nov 11, 2024
...test/java/org/glassfish/jersey/tests/e2e/tls/connector/ConcurrentHttpsUrlConnectionTest.java
Outdated
Show resolved
Hide resolved
dtbaum
reviewed
Nov 11, 2024
| @@ -387,6 +387,10 @@ private ClientResponse _apply(final ClientRequest request) throws IOException { | |||
| sniUri = request.getUri(); | |||
| } | |||
|
|
|||
| if (!DEFAULT_SSL_SOCKET_FACTORY.isInitialized() && "HTTPS".equalsIgnoreCase(sniUri.getScheme())) { | |||
There was a problem hiding this comment.
The check !DEFAULT_SSL_SOCKET_FACTORY.isInitialized() seems to be not thread-save?
There was a problem hiding this comment.
The variable used in isInitialized() is volatile, so it should be thread-safe.
Signed-off-by: jansupol <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.