Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let tests autodiscover their resources #161

Merged
merged 1 commit into from
Mar 1, 2020
Merged

Let tests autodiscover their resources #161

merged 1 commit into from
Mar 1, 2020

Conversation

erdlet
Copy link
Member

@erdlet erdlet commented Feb 26, 2020

To be able to run the tests on any server without the problem of a
not initialized Krazo feature, they are all set to autodiscover their
resources now. This way, they behave like the TCK tests and we can
test specific behavior (like we have in Jersey or RESTEasy) in own tests

Signed-off-by: Erdle, Tobias [email protected]

@erdlet erdlet requested a review from chkal February 26, 2020 13:56
@erdlet erdlet self-assigned this Feb 26, 2020
To be able to run the tests on any server without the problem of a
not initialized Krazo feature, they are all set to autodiscover their
resources now. This way, they behave like the TCK tests and we can
test specific behavior (like we have in Jersey or RESTEasy) in own tests

Signed-off-by: Erdle, Tobias <[email protected]>
Copy link
Contributor

@chkal chkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big +1 for this change!

@chkal chkal added this to the 1.1.0 milestone Feb 27, 2020
Copy link
Contributor

@gtudan gtudan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool - much simpler anyways and doesn't give new users wrong examples.
Should we also do the examples?

@erdlet
Copy link
Member Author

erdlet commented Feb 28, 2020

Should we also do the examples?

+1 for this. I'd propose to do this as part of #28 and finally finish this issue, as it is open for a long time now.

@erdlet erdlet merged commit 6d373b6 into eclipse-ee4j:master Mar 1, 2020
@erdlet erdlet deleted the testsuite-tests-autodiscover-resources branch March 1, 2020 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants