Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handlers for Smart Connector UIExtension #70
base: main
Are you sure you want to change the base?
Handlers for Smart Connector UIExtension #70
Changes from 7 commits
32ceb71
ca2e9b1
510c9f7
85cb92c
b79650e
8b77069
0edc62d
cb71c3b
1f8cb5a
6a88438
19d6020
c6ba7bd
6b01139
c97bc4b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be handled generically. All the required information is present in the typehints of the
DiagramConfiguration
.Could be moved up to the
DefaultSmartConnectorProvider
.I don't expect that this is handled with this PR but we should create a follow-up for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be handled on client side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be handled entirely on client side.
The server should only provide the
selection palette actions
via theRequestContextActions
handler but should not need to know any other implementation details about how they will be handled/rendered on the client side.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed offline we would like to use a more generic
SelectionPaletteProvider
API (that is inline with CommandPaletteProvider and ToolpaletteProvider) and the currentSmartConnector
is then just the default implementation of that provider.So please rename this to
SelectionPaletteProvider
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
this.nodeOperationFilter[selectedNodeType].includes(e)
part can cause an error if theselectedNodeType
does not exist innodeOperationFilter
. Check the updated types provided before.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solution could be something like
!!this.nodeOperationFilter[selectedNodeType]?.includes(e)