Collab advanced #241
Open
Collab advanced #241
+233
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reload logic for RequestModelAction replace commandStack with commandStackManager
tortmayr
requested changes
Oct 7, 2024
|
|
||
| package org.eclipse.glsp.server.utils; | ||
|
|
||
| public class CollaborationUtil { |
There was a problem hiding this comment.
Minor checkstyle issue:
Since this is a utility class it should have a private constructor:
public final class CollaborationUtil {
private CollaborationUtil() {
}
public static final String FALLBACK_SUBCLIENT_ID = "FALLBACK_SUBCLIENT_ID";
}
...rver/src/org/eclipse/glsp/server/internal/gmodel/commandstack/GModelCommandStackFactory.java
Show resolved
Hide resolved
plugins/org.eclipse.glsp.server/src/org/eclipse/glsp/server/command/CommandStackFactory.java
Show resolved
Hide resolved
plugins/org.eclipse.glsp.server/src/org/eclipse/glsp/server/command/CommandStackManager.java
Show resolved
Hide resolved
.../org.eclipse.glsp.server/src/org/eclipse/glsp/server/command/DefaultCommandStackManager.java
Show resolved
Hide resolved
plugins/org.eclipse.glsp.server.emf/src/org/eclipse/glsp/server/emf/EMFModelStateImpl.java
Show resolved
Hide resolved
plugins/org.eclipse.glsp.server.emf/src/org/eclipse/glsp/server/emf/EMFModelState.java
Show resolved
Hide resolved
| @@ -88,7 +88,7 @@ public List<Action> submitInitialModel(final RequestModelAction requestAction) { | |||
| * Therefore we temporarily store the action later retrival | |||
| */ | |||
| this.requestModelAction = Optional.of(requestAction); | |||
| return submitModel(); | |||
| return submitModel(requestAction.getSubclientId()); | |||
There was a problem hiding this comment.
Seems like an accidental change to me. The subClientId should not be used as reason here
...glsp.server/src/org/eclipse/glsp/server/gmodel/AbstractGModelCreateNodeOperationHandler.java
Show resolved
Hide resolved
plugins/org.eclipse.glsp.server/src/org/eclipse/glsp/server/actions/Action.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
How to test
Follow-ups
Changelog