Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#18] Adds formatting for services and an additional example #44

Closed

Merge branch 'main' into iox2-29-pretty-print-service

83cb2eb
Select commit
Loading
Failed to load commit list.
Closed

[#18] Adds formatting for services and an additional example #44

Merge branch 'main' into iox2-29-pretty-print-service
83cb2eb
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed Started 2024-08-09 19:52:08 ago

4 / 16 tasks completed

12 tasks still to be completed

Details

Required Tasks

Task Status
Add sensible notes for the reviewer Incomplete
PR title is short, expressive and meaningful Completed
Relevant issues are linked Completed
Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT Completed
Branch follows the naming format (iox2-123-introduce-posix-ipc-example) Completed
Commit messages have the issue ID ([#123] Add posix ipc example) Incomplete
Commit author matches [Eclipse Contributor Agreement][eca] (and ECA is signed) Incomplete
Tests follow the [best practice for testing][testing] Incomplete
Changelog updated [in the unreleased section][changelog] including API breaking changes Incomplete
Assign PR to reviewer Incomplete
All checks have passed (except task-list-completed) Incomplete
Commits are properly organized and messages are according to the guideline Incomplete
Unit tests have been written for new behavior Incomplete
Public API is documented Incomplete
PR title describes the changes Incomplete
All open points are addressed and tracked via issues Incomplete
https://github.com/eclipse-iceoryx/iceoryx2/blob/main/iceoryx2/src/service/port_factory/publish_subscribe.rs#L24-L34 Incomplete
https://github.com/eclipse-iceoryx/iceoryx2/blob/main/iceoryx2/src/service/port_factory/event.rs#L24-L29 Incomplete