-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#48] Adding audit scripts #49
[#48] Adding audit scripts #49
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add this to doc/release-notes/iceoryx2-unreleased.md
in the workflow
section.
The entry would look like this here:
* add `cargo audit` for security vulnerability checking in dependencies [#49](https://github.com/eclipse-iceoryx/iceoryx2/issues/49)
All the other examples still have the old repo as link, when you edit the file could you please update these links as well - thanks!
When the changelog is updated we can merge this. @elBoberido you know cirrus best, any objections?
Also added for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my point of view. We still might need to add a nightly build but that's for another PR not this one
@@ -18,7 +18,7 @@ | |||
|
|||
### Workflow | |||
|
|||
* Example [#1](https://github.com/larry-robotics/iceoryx2/issues/1) | |||
* add `cargo audit` for security vulnerability checking in dependencies [#49](https://github.com/eclipse-iceoryx/iceoryx2/issues/49) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* add `cargo audit` for security vulnerability checking in dependencies [#49](https://github.com/eclipse-iceoryx/iceoryx2/issues/49) | |
* add `cargo audit` for security vulnerability checking in dependencies [#48](https://github.com/eclipse-iceoryx/iceoryx2/issues/48) |
Please always link to the actual issue instead of the PR :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hydroid7 whoopsie my mistake I mixed up the PR number and the issue number
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, as soon as the issue number in the release notes is corrected we can merge this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add [#48]
to the Fixes release notes
commit message.
Oh, and for future commits, please write the commit messages in imperative so Fix bug
and not Fixes bug
or Fixing bug
. This is just to prevent proliferation and to have a uniform style in the commit messages.
Thanks for being so patient with us :)
8558027
to
43fda38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh no, now there is a merge conflict in the release notes. You have to rebase before it can be merged
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
==========================================
+ Coverage 78.00% 78.01% +0.01%
==========================================
Files 172 172
Lines 18782 18782
==========================================
+ Hits 14650 14653 +3
+ Misses 4132 4129 -3 |
Notes for Reviewer
Pre-Review Checklist for the PR Author
SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Use either 'Closes #123' or 'Relates to #123' to reference the corresponding issue.
Closes #ISSUE-NUMBER