-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#453] Document how to make cross-compilation work with buildroot #502
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of nitpicks. You will also need to register an eclipse account and sign the ECA agreement since we are an eclipse project.
Markdown linting might also bite you, but you can run this script to help: ./internal/scripts/check_markdown_linting.sh --fix
Could you also please fill out the PR template and ensure the open items are addressed, e.g. the commit needs to be prefixed with the issue number for traceability: [#453] Document how to make cross-compilation work with buildroot
@jerry-xie-000 can you also change the commit message to |
I register an eclipse account and sign the ECA agreement and include my github name, but |
@jerry-xie-000 it might take a day to sync everything. If the check still fails after tomorrow, I'll get in contact with the Eclipse Foundation. |
@jerry-xie-000 did the account, you signed the ECA with, use the same e-mail address like you used for the commits? |
Run internal/scripts/check_markdown_linting.sh, seems it's ok now.
Feel free to tell me other issues. |
@jerry-xie-000 Looks good, just need to get that ECA check passing. Have you had a chance to confirm the comment from @elBoberido:
Oh and you will need to reword the commits so that they all have the prefix |
034f1ac
to
68982f3
Compare
Yes, I singed in ECA and github with the same email address. The |
@jerry-xie-000 the ECA Validation Tool does not find |
Notes for Reviewer
Refer to: #453.
Write the steps how to make cross-compilation work with buildroot.
Pre-Review Checklist for the PR Author
Every source code file has a copyright header withSPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)Tests follow the best practice for testingtask-list-completed
)Checklist for the PR Reviewer
Unit tests have been written for new behaviorPublic API is documentedPost-review Checklist for the PR Author
References
Closes #453