feat(rest.service.listing.provider): Added REST Api for Service Listing #4857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfiorani
force-pushed
the
services-rest-listing
branch
from
be81877 to
8a17ffd
Compare
Signed-off-by: SimoneFiorani <[email protected]>
Signed-off-by: SimoneFiorani <[email protected]>
Signed-off-by: SimoneFiorani <[email protected]>
Signed-off-by: SimoneFiorani <[email protected]>
Signed-off-by: SimoneFiorani <[email protected]>
Signed-off-by: SimoneFiorani <[email protected]>
Signed-off-by: SimoneFiorani <[email protected]>
Signed-off-by: SimoneFiorani <[email protected]>
Signed-off-by: SimoneFiorani <[email protected]>
sfiorani
force-pushed
the
services-rest-listing
branch
from
547bcc9 to
360e044
Compare
Signed-off-by: SimoneFiorani <[email protected]>
Signed-off-by: SimoneFiorani <[email protected]>
Signed-off-by: SimoneFiorani <[email protected]>
Signed-off-by: SimoneFiorani <[email protected]>
| name="RequestHandlerRegistry" | ||
| policy="dynamic"/> | ||
|
|
||
| <reference interface="org.osgi.service.useradmin.UserAdmin" |
There was a problem hiding this comment.
We can remove the specific kura.permission.rest.serviceListing role and allow access to this rest API to any authenticated user. If this is done this reference is not required.
|
|
||
| public class InterfacesIdsDTO { | ||
|
|
||
| private final List<String> interfacesIds; |
There was a problem hiding this comment.
You can try changing this to Set, in this way duplicates are removed from request automatically.
| private static final String REQUEST_DEBUG_MESSAGE = "Received request from: '{}'"; | ||
|
|
||
| private static final String APP_ID_MQTT = "SERLIST-V1"; | ||
| private static final String REST_ROLE = "kura.permission.rest.serviceListing"; |
There was a problem hiding this comment.
We can remove the specific kura.permission.rest.serviceListing role and allow access to this rest API to any authenticated user. If this is done this constant is not required.
| } | ||
| } | ||
|
|
||
| public void bindUserAdmin(UserAdmin userAdmin) { |
There was a problem hiding this comment.
This is no longer needed if we are removing the role
Signed-off-by: SimoneFiorani <[email protected]>
Signed-off-by: SimoneFiorani <[email protected]>
Signed-off-by: SimoneFiorani <[email protected]>
nicolatimeus
approved these changes
Sep 20, 2023
pierantoniomerlino
pushed a commit
that referenced
this pull request
Sep 26, 2023
…ng (#4857) * Added temporary bundle Signed-off-by: SimoneFiorani <[email protected]> * General bundle for both SSL and Keystore services Signed-off-by: SimoneFiorani <[email protected]> * GET works correctly, POST needs filter implementation Signed-off-by: SimoneFiorani <[email protected]> * Added POST api Signed-off-by: SimoneFiorani <[email protected]> * Turned apis into general ones: get and post working correctly Signed-off-by: SimoneFiorani <[email protected]> * Updated bundle name and structure. Only tests missing Signed-off-by: SimoneFiorani <[email protected]> * Added tests. General improvements Signed-off-by: SimoneFiorani <[email protected]> * Changed test response on full list test Signed-off-by: SimoneFiorani <[email protected]> * Updated test Signed-off-by: SimoneFiorani <[email protected]> * Updated tests Signed-off-by: SimoneFiorani <[email protected]> * Added MQTT test, fixed wrong POST body, renamed various files and bundle Signed-off-by: SimoneFiorani <[email protected]> * Updated provider Signed-off-by: SimoneFiorani <[email protected]> * Trying to resolve build failures Signed-off-by: SimoneFiorani <[email protected]> * Added principal check. Tests updated Signed-off-by: SimoneFiorani <[email protected]> * Generale clean up Signed-off-by: SimoneFiorani <[email protected]> * Update ServiceListingEndpointsTest.java * Missing headers added Signed-off-by: SimoneFiorani <[email protected]> * Removed <sorted> word from service --------- Signed-off-by: SimoneFiorani <[email protected]>
GregoryIvo
pushed a commit
to GregoryIvo/kura
that referenced
this pull request
Sep 28, 2023
…ng (eclipse-kura#4857) * Added temporary bundle Signed-off-by: SimoneFiorani <[email protected]> * General bundle for both SSL and Keystore services Signed-off-by: SimoneFiorani <[email protected]> * GET works correctly, POST needs filter implementation Signed-off-by: SimoneFiorani <[email protected]> * Added POST api Signed-off-by: SimoneFiorani <[email protected]> * Turned apis into general ones: get and post working correctly Signed-off-by: SimoneFiorani <[email protected]> * Updated bundle name and structure. Only tests missing Signed-off-by: SimoneFiorani <[email protected]> * Added tests. General improvements Signed-off-by: SimoneFiorani <[email protected]> * Changed test response on full list test Signed-off-by: SimoneFiorani <[email protected]> * Updated test Signed-off-by: SimoneFiorani <[email protected]> * Updated tests Signed-off-by: SimoneFiorani <[email protected]> * Added MQTT test, fixed wrong POST body, renamed various files and bundle Signed-off-by: SimoneFiorani <[email protected]> * Updated provider Signed-off-by: SimoneFiorani <[email protected]> * Trying to resolve build failures Signed-off-by: SimoneFiorani <[email protected]> * Added principal check. Tests updated Signed-off-by: SimoneFiorani <[email protected]> * Generale clean up Signed-off-by: SimoneFiorani <[email protected]> * Update ServiceListingEndpointsTest.java * Missing headers added Signed-off-by: SimoneFiorani <[email protected]> * Removed <sorted> word from service --------- Signed-off-by: SimoneFiorani <[email protected]>
This was referenced Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new REST API that can retrieve the list of
kura.service.pidof services running on Kura, or the same list but filtered through the interfaces that the services must implement.Methods added:
GET method -->
serviceListing/v1/list--> get all servicesPOST method -->
serviceListing/v1/list/byAllInterfaces--> get filtered services"interfacesIds" body example:
Related Issue:
Description of the solution adopted:
Screenshots:
Manual Tests:
Any side note on the changes made: