-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rest.packages.provider): add deploy/v2
Rest API
#4868
Merged
pierantoniomerlino
merged 50 commits into
eclipse-kura:develop
from
mattdibi:feat/deploy_packages_rest_api
Oct 10, 2023
Merged
feat(rest.packages.provider): add deploy/v2
Rest API
#4868
pierantoniomerlino
merged 50 commits into
eclipse-kura:develop
from
mattdibi:feat/deploy_packages_rest_api
Oct 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdibi
changed the title
feat(rest.packages): add
feat(rest.packages.provider): add Sep 27, 2023
deploy/v2
RestAPIdeploy/v2
Rest API
kura/org.eclipse.kura.rest.packages.provider/OSGI-INF/deployment_rest_service.xml
Outdated
Show resolved
Hide resolved
kura/org.eclipse.kura.rest.packages.provider/OSGI-INF/deployment_rest_service.xml
Outdated
Show resolved
Hide resolved
pierantoniomerlino
approved these changes
Oct 2, 2023
WARNING: Build is still broken
WARNING: build still broken
WARNING: Failing
WARNING: Passing even if it shouldn't
mattdibi
force-pushed
the
feat/deploy_packages_rest_api
branch
from
October 10, 2023 07:25
fd6188a
to
d674d88
Compare
This was referenced Oct 11, 2023
3 tasks
This was referenced Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
deploy/v2
RestAPI endpoint to the Kura codebase. The endpoint was already available in theansible
bundle but it is now being promoted to core.In its current form it is a 1:1 matching with the old implementation, but I will contribute additional functionalities in the next PRs.
Roadmap:
deploy/v2
in its current form (feat(rest.packages.provider): adddeploy/v2
Rest API #4868)multipart/form-data
install
endpointChangelog:
org.eclipse.kura.rest.packages.provider
containing the implementation codeorg.eclipse.kura.rest.packages.provider.test
containing both unit and integration testsDifferences with the existing implementation: differently from the
ansible
bundle implementation I had to:Tests
I ran the following tests on a Nvidia Jetson Nano running the latest buid with this PR
then used
curl
to run the requests.Get installed packages
after installing the Wire Script Filter
Uninstall a package
The package is correctly uninstalled
Install package from URL
The package is correctly installed (after updating the HTTPS certificate)
RestAPI Documentation
Get installed packages
/deploy/v2/
Description
Responses
Install package from URL
/deploy/v2/_install
Description
Responses
Uninstall a package
/deploy/v2/{name}
Description
Responses