Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed UI issues with the modem section #4869

Merged
merged 4 commits into from
Oct 2, 2023
Merged

Conversation

MMaiero
Copy link
Contributor

@MMaiero MMaiero commented Sep 26, 2023

Note: We are using the Conventional Commits convention for our pull request titles. Please take a look at the PR title format document for the supported types and scopes.

Brief description of the PR. [e.g. Added null check on object to avoid NullPointerException]

Related Issue: This PR fixes/closes {issue number}

Description of the solution adopted: A more detailed description of the changes made to solve/close one or more issues. If the PR is simple and easy to understand this section can be skipped

Screenshots: If applicable, add screenshots to help explain your solution

Manual Tests: Optional description of the tests performed to check correct functioning of changes, useful for an efficient review

Any side note on the changes made: Description of any other change that has been made, which is not directly linked to the issue resolution [e.g. Code clean up/Sonar issue resolution]

@MMaiero
Copy link
Contributor Author

MMaiero commented Oct 2, 2023

CI Issue pending: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/3750
Build otherwise working and proved by Nemanja.
Merging

@MMaiero MMaiero merged commit ec2d052 into develop Oct 2, 2023
1 check passed
@code-incubus
Copy link

@marcellorinaldo @MMaiero I checked the fix provided by Matteo and it looks fine at my end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants