feat(sparkplug): added DataTransport layer #5077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcello Martina <[email protected]>
Signed-off-by: Marcello Martina <[email protected]>
There was a problem hiding this comment.
Why are we adding paho as bundle library rather than using the one in the target platform ?
There was a problem hiding this comment.
It is not available in distrib.
salvatore-coppola
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
DataTransportlayer for the Sparkplug Cloud Connection.Related Issue: #5076.
Description of the solution adopted: The
CloudEndpointlayer has a reference to theDataTransportlayer to inject Sparkplug-related properties. The Paho library has been included manually inlibas fororg.eclipse.kura.core. See https://github.com/eclipse/kura/tree/develop/kura/org.eclipse.kura.core/lib.Screenshots: N/A.
Manual Tests: N/A.
Any side note on the changes made: N/A.