Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Limit the UI certificate add to a single PEM cert #5183

Merged
merged 4 commits into from
Mar 27, 2024

Conversation

MMaiero
Copy link
Contributor

@MMaiero MMaiero commented Mar 15, 2024

Tested in raspberry PI

@salvatore-coppola
Copy link
Contributor

@MMaiero we need to add the japanase translation for the new strings added on message.properties

@MMaiero
Copy link
Contributor Author

MMaiero commented Mar 18, 2024

@MMaiero we need to add the japanase translation for the new strings added on message.properties

@marcellorinaldo how do you usually manage this?

@marcellorinaldo
Copy link
Contributor

marcellorinaldo commented Mar 18, 2024

@MMaiero we need to add the japanase translation for the new strings added on message.properties

@marcellorinaldo how do you usually manage this?

Google translate usually works fine. We then ask a japanese collegue if the translation is OK.

@MMaiero
Copy link
Contributor Author

MMaiero commented Mar 21, 2024

Reviewed by Yuki san

@MMaiero
Copy link
Contributor Author

MMaiero commented Mar 27, 2024

Forcing merge.
The build succeeds locally but we are facing an issue in the CI connection to Sonar. An issue has been raised few weeks ago to the Eclipse Team: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4422

@MMaiero MMaiero merged commit ccbc136 into develop Mar 27, 2024
5 of 6 checks passed
@MMaiero MMaiero deleted the feat_cert_single_add branch March 27, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants