fix: position not updated when fix is lost #5565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SimoneFiorani <[email protected]>
Signed-off-by: SimoneFiorani <[email protected]>
sfiorani
changed the title
Signed-off-by: SimoneFiorani <[email protected]>
Signed-off-by: SimoneFiorani <[email protected]>
MMaiero
approved these changes
Nov 15, 2024
eclipse-kura-bot
pushed a commit
that referenced
this pull request
Nov 15, 2024
* fix: position not updated when fix is lost Signed-off-by: SimoneFiorani <[email protected]> * refactor: refactored conditions to parse data Signed-off-by: SimoneFiorani <[email protected]> * fix: small issues and test coverage Signed-off-by: SimoneFiorani <[email protected]> * fix: reduced method complexity Signed-off-by: SimoneFiorani <[email protected]> --------- Signed-off-by: SimoneFiorani <[email protected]> (cherry picked from commit c685fdc)
MMaiero
pushed a commit
that referenced
this pull request
Nov 16, 2024
…5567) fix: position not updated when fix is lost (#5565) * fix: position not updated when fix is lost Signed-off-by: SimoneFiorani <[email protected]> * refactor: refactored conditions to parse data Signed-off-by: SimoneFiorani <[email protected]> * fix: small issues and test coverage Signed-off-by: SimoneFiorani <[email protected]> * fix: reduced method complexity Signed-off-by: SimoneFiorani <[email protected]> --------- Signed-off-by: SimoneFiorani <[email protected]> (cherry picked from commit c685fdc) Co-authored-by: sfiorani <[email protected]>
MMaiero
pushed a commit
that referenced
this pull request
Dec 20, 2024
* fix: position not updated when fix is lost Signed-off-by: SimoneFiorani <[email protected]> * refactor: refactored conditions to parse data Signed-off-by: SimoneFiorani <[email protected]> * fix: small issues and test coverage Signed-off-by: SimoneFiorani <[email protected]> * fix: reduced method complexity Signed-off-by: SimoneFiorani <[email protected]> --------- Signed-off-by: SimoneFiorani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that prevents the update of the position fix whenever this was missed. Indeed, the RawLocation is provided by MM only when the position is fixed, otherwise only the raw data is provided.
Before this changes the check
would prevent the position fix update through the nmea data: consequently, once the fix was get it cannot be lost.
When this PR is opened, Modem Manager ALWAYS provides the nmea data, while the raw data is provided only if the first has valid fix. For these reasons the provider would act as follows:
Related Issue:
Description of the solution adopted:
Screenshots:
Manual Tests:
Any side note on the changes made: