fix(web2): Fixed wireless mode selection #5583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pierantoniomerlino <[email protected]>
MMaiero
approved these changes
Nov 26, 2024
eclipse-kura-bot
pushed a commit
that referenced
this pull request
Nov 27, 2024
Fixed wireless mode selection Signed-off-by: pierantoniomerlino <[email protected]> (cherry picked from commit d4b7cfd)
MMaiero
pushed a commit
that referenced
this pull request
Nov 27, 2024
) fix(web2): Fixed wireless mode selection (#5583) Fixed wireless mode selection Signed-off-by: pierantoniomerlino <[email protected]> (cherry picked from commit d4b7cfd) Co-authored-by: Pierantonio Merlino <[email protected]>
MMaiero
pushed a commit
that referenced
this pull request
Dec 20, 2024
Fixed wireless mode selection Signed-off-by: pierantoniomerlino <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a weird behavior in the Wireless tab when the
Enable for WANis selected.Related Issue: This PR fixes/closes N/A
Description of the solution adopted: When the Wireless tab is selected and the interface is configured as
Enabled for WANand DHCP, the Station Mode is not selectable. This PR fixes this wrong behavior. The cause of this is a wrong enum comparison.BTW, the
release-5.6.0contains the wrong comparison, while the Kura 5.6.0 tag doesn't.