-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(asset.provider): Added integer and float as possible Scale and Offset type #5584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salvatore-coppola
force-pushed
the
fix-rest-scale-offset
branch
from
November 25, 2024 15:04
a9fb54c
to
04d7a6f
Compare
salvatore-coppola
force-pushed
the
fix-rest-scale-offset
branch
from
November 27, 2024 13:25
14ad3a0
to
19cf556
Compare
kura/org.eclipse.kura.api/src/main/java/org/eclipse/kura/channel/Channel.java
Outdated
Show resolved
Hide resolved
kura/org.eclipse.kura.api/src/main/java/org/eclipse/kura/channel/Channel.java
Outdated
Show resolved
Hide resolved
kura/org.eclipse.kura.api/src/main/java/org/eclipse/kura/channel/Channel.java
Outdated
Show resolved
Hide resolved
salvatore-coppola
changed the title
fix(asset.provider): Scale and offset by default are null
fix(asset.provider): Added integer and float as possible Scale and Offset type
Nov 29, 2024
kura/org.eclipse.kura.api/src/main/java/org/eclipse/kura/channel/Channel.java
Outdated
Show resolved
Hide resolved
kura/org.eclipse.kura.api/src/main/java/org/eclipse/kura/channel/Channel.java
Outdated
Show resolved
Hide resolved
....provider/src/main/java/org/eclipse/kura/internal/asset/provider/BaseAssetConfiguration.java
Outdated
Show resolved
Hide resolved
pierantoniomerlino
approved these changes
Dec 3, 2024
MMaiero
pushed a commit
that referenced
this pull request
Dec 20, 2024
…fset type (#5584) * Set default scale and offset value to Optional.empty() * Fixed tests * fixed test 2 * fixed test 3 * Fixed test * Added missing type in the webui * Added missing types in ScaleOffsetType copy * fixed bug * Reverted scale and offset default state tu 1.0d and 0.0d * Fixed tests * added test coverage and fixed missing types in datatype method * fixed typos * restored old code * Restored and deprecated old methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added integer and float as possible Scale and Offset type