ci: switch to Java 17 for CI builds #5602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
mattdibi
force-pushed
the
MMaiero-patch-1
branch
from
cf4142d to
b934941
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
mattdibi
force-pushed
the
MMaiero-patch-1
branch
from
b934941 to
ef0ced3
Compare
|
@MMaiero I tested it locally on a Java17 installation. It does work simply by adding How do we want to proceed now?
|
|
Yes to both. Le't's use the command line instead of the configuration in pom files. |
mattdibi
force-pushed
the
MMaiero-patch-1
branch
from
ef0ced3 to
c500692
Compare
mattdibi
changed the title
mattdibi
force-pushed
the
MMaiero-patch-1
branch
from
ca9c9b1 to
ef1a6a2
Compare
|
Good news is that it's working:
Bad news is that there are broken tests since we are not running them regularly and we'll need to fix them... |
|
For documentation purposes: we decided to disable the failing tests for now and fix them at a later date. |
mattdibi
force-pushed
the
MMaiero-patch-1
branch
from
ee336ea to
4481dd4
Compare
mattdibi
changed the title
mattdibi
previously approved these changes
Dec 10, 2024
mattdibi
force-pushed
the
MMaiero-patch-1
branch
2 times, most recently
from
7b7bcfe to
0584e26
Compare
mattdibi
force-pushed
the
MMaiero-patch-1
branch
from
0584e26 to
e796705
Compare
mattdibi
approved these changes
Dec 10, 2024
|
Do not merge yet, have to check something... |
marcellorinaldo
approved these changes
Dec 10, 2024
|
@salvatore-coppola if you don't see any issues I would proceed with merging this |
This was referenced Dec 13, 2024
MMaiero
added a commit
that referenced
this pull request
Dec 20, 2024
* ci: Added Surefire rerun policy * ci: switch to Java17 for CI builds * test: disabled DeploymentAgentTest * test: disabled LinuxNetworkUtilTest * test: disabled PackagesRestServiceTest * test: re-enable ConfigurationRestServiceTest * test: fix NMDbusConnectorTest * build: remove `core-dp` and `can-dp` from `buildAll` target * docs: update README to refere to Java 17 only * ci: refactor Jenkinsfile for improved error reporting and more granular timeouts --------- Co-authored-by: Mattia Dal Ben <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches to Java17 for CI builds
This PR additionally performs the following:
buildAlltargetDetails
This PR started off as a simple update to the
manve-surefire-pluginrerun policy. We later found out that we need to switch to Java 17 for it to work properly and decided to do so since we needed it anyway (see: #5478)Then we found out that some tests fails in the Java17 profile which prompted us to disable them and address the issue at a later date (see: https://eurotech.atlassian.net/browse/ECESF-8549)
Finally, we removed all
.dpfrom thebuildAlltarget since we cannot generate.dppackages with Java17 and thedistribbuild would fail since it was looking for them (see https://eurotech.atlassian.net/browse/ECESF-3770)Disabled tests
NMDbusConnectorTestfixed in 4481dd4