-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(distrib): installers renaming and corrected metadata #5609
Conversation
Signed-off-by: Marcello Rinaldo Martina <[email protected]>
Signed-off-by: Marcello Rinaldo Martina <[email protected]>
Signed-off-by: Marcello Rinaldo Martina <[email protected]>
Signed-off-by: Marcello Rinaldo Martina <[email protected]>
…d opens in launch config Signed-off-by: Marcello Rinaldo Martina <[email protected]>
Signed-off-by: Marcello Rinaldo Martina <[email protected]>
Signed-off-by: Marcello Rinaldo Martina <[email protected]>
Signed-off-by: Marcello Rinaldo Martina <[email protected]>
… in ant script Signed-off-by: Marcello Rinaldo Martina <[email protected]>
Signed-off-by: Marcello Rinaldo Martina <[email protected]>
Signed-off-by: Marcello Rinaldo Martina <[email protected]>
Signed-off-by: Marcello Rinaldo Martina <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcellorinaldo Why did you rename generic-x86_64
-> x86_64
. Shouldn't this be called amd64
given we agreed to follow debian architecture naming scheme? (see: https://wiki.debian.org/SupportedArchitectures)
Similarly aarch64
should be called arm64
...
Signed-off-by: Marcello Rinaldo Martina <[email protected]>
As per our offline discussion we decided to:
|
Signed-off-by: Marcello Rinaldo Martina <[email protected]>
Signed-off-by: Marcello Rinaldo Martina <[email protected]>
…ion>_<deb-arch>.deb Signed-off-by: Marcello Rinaldo Martina <[email protected]>
Signed-off-by: Marcello Rinaldo Martina <[email protected]>
With the changes in this PR we now have: mvn -N -f kura/distrib/pom.xml help:all-profiles
Built with Java8:
Similarly the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* style: added comments for better reachability Signed-off-by: Marcello Rinaldo Martina <[email protected]> * refactor(distrib): renamed generic-aarch64 profiles into aarch64 Signed-off-by: Marcello Rinaldo Martina <[email protected]> * refactor(distrib): renamed generic-arm32 profiles into armhf Signed-off-by: Marcello Rinaldo Martina <[email protected]> * refactor(distrib): renamed generic-x86_64 profiles into x86_64 Signed-off-by: Marcello Rinaldo Martina <[email protected]> * refactor(distrib): removed Java version check in launch scripts, added opens in launch config Signed-off-by: Marcello Rinaldo Martina <[email protected]> * refactor(distrib): installer metadata changes for aarch64 Signed-off-by: Marcello Rinaldo Martina <[email protected]> * refactor(distrib): installer metadata changes for armhf Signed-off-by: Marcello Rinaldo Martina <[email protected]> * refactor(distrib): installer metadata changes for x86_64 Signed-off-by: Marcello Rinaldo Martina <[email protected]> * refactor(distrib): removed non-existing references to kura.init files in ant script Signed-off-by: Marcello Rinaldo Martina <[email protected]> * refactor(distrib): changed kura.os.version from raspbian to Linux Signed-off-by: Marcello Rinaldo Martina <[email protected]> * refactor(distrib): fixed Maintainer metadata field Signed-off-by: Marcello Rinaldo Martina <[email protected]> * feat(distrib): added Homepage metadata field Signed-off-by: Marcello Rinaldo Martina <[email protected]> * refactor(distrib): changed kura.os.version from linux to debian Signed-off-by: Marcello Rinaldo Martina <[email protected]> * fix(distrib): corrected nn profiles names Signed-off-by: Marcello Rinaldo Martina <[email protected]> * fix(distrib): corrected docker metadata Signed-off-by: Marcello Rinaldo Martina <[email protected]> * fix(distrib): changed installer .deb names to match <pack-name>_<version>_<deb-arch>.deb Signed-off-by: Marcello Rinaldo Martina <[email protected]> * fix: removing wrong commited files Signed-off-by: Marcello Rinaldo Martina <[email protected]> --------- Signed-off-by: Marcello Rinaldo Martina <[email protected]>
This PR renames the installers by removing the
generic
prefix which is no more needed since we removed the specific profiles:generic-arm32
->armhf
generic-aarch64
->aarch64
generic-x86_64
->x86_64
In addition, this PR fixes the metadata information for the installers and does some other changes.
NN packages renaming
The installed package name for non-networking profiles is now
kura-nn
instead ofkura
.Installer files renaming
Installation
.deb
files are renamed to follow the debian conventionpackage_version_architecture.type
[8] (supported architectures in [4]):kura_6.0.0_generic-arm32_installer
->kura_6.0.0_armhf.deb
kura_6.0.0_generic-arm32-nn_installer
->kura-nn_6.0.0_armhf.deb
kura_6.0.0_generic-arm64_installer
->kura_6.0.0_arm64.deb
kura_6.0.0_generic-arm64-nn_installer
->kura-nn_6.0.0_arm64.deb
kura_6.0.0_generic-x86_64_installer
->kura_6.0.0_amd64.deb
kura_6.0.0_generic-x86_64-nn_installer
->kura-nn_6.0.0_amd64.deb
Changes to start scripts
The launch scripts have been modified to remove the check of the running JRE for inserting the add-opens launch optionss. We had this function to make the framework executable also on Java 8.
Changes to installers metadata
Debian metadata changes to:
Section: misc
->Section: admin
(Utilities to administer system resources, manage user accounts, etc. [1][2])Priority
fromlow
tooptional
[3]Architecture
changing fromall
to the specific ones [4]Description
field changed to have the first line as synopsis [5]Maintainer
field changed to be compliant with format described in [6]Homepage
filed, since it was otherwise defaulted to something else [7]For testing purposes, you can show the package info after having installed kura with:
References:
[1] https://www.debian.org/doc/debian-policy/ch-archive.html#s-subsections
[2] https://packages.debian.org/unstable/
[3] https://www.debian.org/doc/debian-policy/ch-archive.html#priorities
[4] https://wiki.debian.org/SupportedArchitectures
[5] https://www.debian.org/doc/debian-policy/ch-controlfields.html#description
[6] https://www.debian.org/doc/debian-policy/ch-controlfields.html#maintainer
[7] https://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-homepage
[8] https://www.debian.org/doc/manuals/debian-faq/pkg-basics.en.html