Use const char * instead of char * #7446
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewhall2
requested review from
fjeremic,
0xdaryl and
mstoodle
as code owners
matthewhall2
force-pushed
the
openxl-debug-string-warnings
branch
2 times, most recently
from
418280f
to
6656659
Compare
matthewhall2
force-pushed
the
openxl-debug-string-warnings
branch
from
673967d
to
8180eb8
Compare
Fixes many warnings when passing in string literal Signed-off-by: Matthew Hall <[email protected]>
matthewhall2
force-pushed
the
openxl-debug-string-warnings
branch
from
8180eb8
to
0c42363
Compare
|
@r30shah please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed methods that get passed string literals to accept
const char *instead ofchar *.This suppresses the warning: ISO C++11 does not allow conversion from string literal to 'char *' when they are used.
https://hyc-runtimes-jenkins.swg-devops.com/job/jvm.29.personal/34233/