Stop recognizing UTF16_Encoder.encodeUTF16 methods #7548
Merged
+25
−140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knn-k
force-pushed
the
removeEncodeUTF16
branch
from
879aab5 to
a9445ba
Compare
|
Jenkins build all |
|
This PR requires a coordinated merge with eclipse-openj9/openj9#20613. |
This was referenced Nov 18, 2024
knn-k
requested review from
vijaysun-omr,
dsouzai,
0xdaryl and
mstoodle
as code owners
hzongaro
reviewed
Nov 26, 2024
There was a problem hiding this comment.
I believe that the only uses of OMR::CodeGenerator::getSupportsEncodeUtf16LittleWithSurrogateTest, OMR::CodeGenerator::getSupportsEncodeUtf16BigWithSurrogateTest and the JIT option TR_DisableUTF16BEEncoder are being removed by OpenJ9 pull request eclipse-openj9/openj9#20613. I think those methods and option can be removed from OMR.
May I also ask you to correct the name of the class in the commit message? I believe it was named sun.nio.cs.UTF16_Encoder
knn-k
force-pushed
the
removeEncodeUTF16
branch
from
a9445ba to
cf31fe8
Compare
knn-k
changed the title
|
Jenkins build all |
knn-k
force-pushed
the
removeEncodeUTF16
branch
from
cf31fe8 to
613a8de
Compare
|
I removed the methods |
|
Jenkins build all |
This commit removes the code for encodeUTF16Big() and encodeUTF16Little() methods in sun.nio.cs.UTF16_Encoder from method recognition, and removes related helper functions.
knn-k
force-pushed
the
removeEncodeUTF16
branch
from
613a8de to
707d080
Compare
|
Jenkins build all |
|
I additionally removed JIT options |
knn-k
added a commit
to knn-k/omr
that referenced
this pull request
Dec 2, 2024
This commit restores the helper entries for encodeUTF16Big and encodeUTF16Little for p and x platforms that were removed by eclipse-omr#7548. Signed-off-by: KONNO Kazuhiro <[email protected]>
knn-k
added a commit
to knn-k/omr
that referenced
this pull request
Dec 2, 2024
This commit restores the changes for encodeUTF16Big and encodeUTF16Little that were removed by eclipse-omr#7548. Signed-off-by: KONNO Kazuhiro <[email protected]>
knn-k
added a commit
to knn-k/omr
that referenced
this pull request
Dec 2, 2024
This commit restores the helper entries for encodeUTF16Big and encodeUTF16Little for p and x platforms that were removed by eclipse-omr#7548. Signed-off-by: KONNO Kazuhiro <[email protected]>
knn-k
added a commit
to knn-k/omr
that referenced
this pull request
Dec 2, 2024
This commit restores the helper entries for encodeUTF16Big and encodeUTF16Little for p and x platforms that were removed by eclipse-omr#7548. Signed-off-by: KONNO Kazuhiro <[email protected]>
knn-k
added a commit
to knn-k/omr
that referenced
this pull request
Dec 2, 2024
This commit restores the helper entries for encodeUTF16Big and encodeUTF16Little for p and x platforms that were removed by eclipse-omr#7548. Signed-off-by: KONNO Kazuhiro <[email protected]>
knn-k
added a commit
to knn-k/omr
that referenced
this pull request
Dec 2, 2024
This commit restores the changes for encodeUTF16Big and encodeUTF16Little that were removed by eclipse-omr#7548. Signed-off-by: KONNO Kazuhiro <[email protected]>
knn-k
added a commit
to knn-k/omr
that referenced
this pull request
Dec 2, 2024
This commit restores the changes for encodeUTF16Big and encodeUTF16Little that were removed by eclipse-omr#7548. Signed-off-by: KONNO Kazuhiro <[email protected]>
knn-k
added a commit
to knn-k/omr
that referenced
this pull request
Dec 3, 2024
This commit restores the changes for encodeUTF16Big and encodeUTF16Little that were removed by eclipse-omr#7548. Signed-off-by: KONNO Kazuhiro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the code for encodeUTF16Big() and encodeUTF16Little() methods in sun.nio.cs.UTF16_Encoder from method recognition, and removes related helper functions.