Adjust bound for out-of-line call to StringUTF16.toBytes #20058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recognized Call Transformer generates IL that implements an inline version of StringUTF16.toBytes for values in the range [0,0x3fffffff], and that falls back to calling the Java implementation otherwise. In JDK levels up to 22, the Java implementation throws an OutOfMemoryException if the length is greater than 0x3fffffff. JDK Level 23, however, was changed to throw an OutOfMemoryException if the length is greater than or equal to 0x3fffffff. This change alters the IL that Recognized Call Transformer generates to fall back to the Java implementation if the length is greater than or equal to 0x3fffffff, so that it will work with all JDK levels. Signed-off-by: Henry Zongaro <[email protected]>
|
Jenkins test sanity,sanity.openjdk all jdk21,jdk23 |
|
The code changes look fine, but can you sort through all the test failures to see if there are any real ones in there pertaining to this PR? |
0xdaryl
approved these changes
Aug 27, 2024
|
Pls create PRs for 0.47 and 0.48 |
This was referenced Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recognized Call Transformer generates IL that implements an inline version of
StringUTF16.toBytesfor values in the range [0,0x3fffffff], and that falls back to calling the Java implementation otherwise. In JDK levels up to 22, the Java implementation throws anOutOfMemoryExceptionif the length is greater than 0x3fffffff. JDK Level 23, however, was changed to throw anOutOfMemoryExceptionif the length is greater than or equal to 0x3fffffff.This change alters the IL that Recognized Call Transformer generates to fall back to the Java implementation if the length is greater than or equal to 0x3fffffff, so that it will work with all JDK levels.
Fixes: #20021