Always create nullable array before null-restricted #20139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theresa-m
added
comp:vm
project:valhalla
hangshao0
reviewed
Sep 10, 2024
hangshao0
reviewed
Sep 10, 2024
Signed-off-by: Theresa Mammarella <[email protected]>
theresa-m
force-pushed
the
nr_array_2
branch
from
de527a5 to
ff1d09b
Compare
|
Jenkins test sanity,extended zlinuxval jdknext |
|
Jenkins test sanity amac jdk21 |
hangshao0
approved these changes
Sep 11, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always create a nullable array before a null-restricted array to better align with JIT assumptions that the nullable array should exist. See discussion #19914 (comment)
I also defined J9CLASS_GET_NULLRESTRICTED_ARRAY outside of J9VM_OPT_VALHALLA_FLATTENABLE_VALUE_TYPES for JIT use #20112 (comment)
fyi @a7ehuo
Related to #17340