Rename OffHeap macro in JIT code #20494
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fyi: @zl-wang @amicic @keithc-ca |
|
I expect references in OMR should be fixed as well; see https://github.com/search?q=repo%3Aeclipse-omr%2Fomr%20J9VM_GC_ENABLE_SPARSE_HEAP_ALLOCATION&type=code. |
|
Yes, its being fixed by eclipse-omr/omr#7513 |
amicic
approved these changes
Nov 5, 2024
Signed-off-by: Abdulrahman Alattas <[email protected]>
|
jenkins build aix,plinux |
|
Jenkins build plinux,aix |
|
Jenkins compile aix,plinux jdk8,jdk23 |
|
@zl-wang We should probably do some testing on other platforms: this isn't only about POWER. |
|
sure |
|
Jenkins compile xlinux,zlinux,win jdk8,jdk23 |
|
Jenkins test sanity.functional alinux,amac jdk8,jdk23 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #20461 defining the OffHeap macro and renaming it, this PR changes the usage of the macro to the new name in the JIT code, from
J9VM_GC_ENABLE_SPARSE_HEAP_ALLOCATIONtoJ9VM_GC_SPARSE_HEAP_ALLOCATION.With this PR the OffHeap JIT code will be first compiled with builds but OffHeap is still disabled.
Testing:
https://hyc-runtimes-jenkins.swg-devops.com/job/Pipeline-Build-Test-Personal/24804/
https://hyc-runtimes-jenkins.swg-devops.com/job/Pipeline-Build-Test-Personal/24925/