Support Java Behaviour w.r.t Math.max and Math.min for Floating Points #20530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds java_lang_Math_max/min_float/double as a recognized method - Adds a SupportsInlineMath_MaxMin_FD flag to the Z code generator - Flag is only set in Z if the TR_disableInlineMath_MaxMin_FD environment variable is not set - If the flag is set, call nodes are transformed to a functionally equivalent tree that uses fmin/fmax/dmin/dmax nodes Signed-off-by: Matthew Hall <[email protected]>
- spearate evaluators for J9 vs OMR to support differing behaviour (OMR complies with IEEE_754, while J9 returns the first NaN (if present) - +0.0 compares as strictly greater than -0.0 Signed-off-by: Matthew Hall <[email protected]>
Add functional tests for `Math.max` and `Math.min`: - to test specific float and double corner cases - test with NaN, +0, & -0, values to confirm respective omr changes - test all possible execution paths Signed-off-by: Matthew Hall <[email protected]>
|
@matthewhall2 Can this be move out of draft if your internal testing is finished and all good? |
A few jobs are still waiting to run, will move it out of draft once they finish |
|
jenkins test sanity zlinux,xlinux jdk11,jdk21 |
|
Based on the build links shared and and passing JDK11/JDK21 sanity builds on the PR, and as explicit review was done where this PR, fixes the issue with the test, approving the change and merging this one. @matthewhall2 Please keep an eye on the OpenJ9 Jenkins build and VMFarm builds if there is anything pops up. |
|
Reverting due to #20594 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vmfarm: http://vmfarm.rtp.raleigh.ibm.com/build_info.php?build_id=81412
personal build test: https://hyc-runtimes-jenkins.swg-devops.com/job/Pipeline-Build-Test-Personal/24986/