Support JEP491 (Part 1) #20566
Merged
Support JEP491 (Part 1) #20566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jack Lu <[email protected]>
Removed: Blocker class PinnedThreadPrinter class NativeReferenceQueue class Signed-off-by: Jack Lu <[email protected]>
|
FYI @JasonFengJ9 |
|
@tajila can you please take a look at this |
This was referenced Nov 13, 2024
tajila
reviewed
Nov 13, 2024
jcl/src/java.base/share/classes/java/lang/ref/ReferenceQueue.java
Outdated
Show resolved
Hide resolved
tajila
reviewed
Nov 13, 2024
| @@ -294,6 +294,21 @@ public final void wait(long time, int frac) throws InterruptedException { | |||
| Blocker.end(blocking); | |||
| } | |||
| } | |||
| /*[ELSE] JAVA_SPEC_VERSION < 24 */ | |||
| if ((time < 0) || (frac < 0)) { | |||
| throw new IllegalArgumentException("timeout value is negative"); | |||
There was a problem hiding this comment.
I think we may already throw these exceptions internally
There was a problem hiding this comment.
we do, I added this to match RI's bytecode as it would be a faster path to avoid having to call into native.
Signed-off-by: Jack Lu <[email protected]>
Signed-off-by: Jack Lu <[email protected]>
|
jenkins test sanity alinux64 jdk23 |
|
|
The ECA checks out manually. We can either ignore the failures, or need to push changes to cause the check to run again. |
|
I guess adding the label caused the check to rerun, it's passed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to support compile/partial functionality
Part of #20562
Signed-off-by: Jack Lu [email protected]