Fix JFR synchronization issues #20593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test funcitonal.sanity xlinux jdk17 |
1 similar comment
|
jenkins test funcitonal.sanity xlinux jdk17 |
|
jenkins test sanity xlinux jdk17 |
|
jenkins test sanity xlinux jdk11 |
tajila
force-pushed
the
jfr3
branch
3 times, most recently
from
9e23786 to
0b67634
Compare
|
@gacholio Please review these changes |
gacholio
reviewed
Nov 14, 2024
gacholio
reviewed
Nov 14, 2024
|
@gacholio changes ready for another look |
- Assert that VM access is always held while interacting with JFR buffer - Previously, we stored classhashtable entries. Class hashtable can grow and these entries become stale. Instead use romClass as the key for the package table - Previously, we iterated ClassEntry hashtables while adding entries to them (see fixupShallowEntries), this results in corruption. Instead we now make a list of the classes we need to scan (findShallowEntries), then walk the list and add scan entries after. - Dont create tables with J9HASH_TABLE_ALLOW_SIZE_OPTIMIZATION since we cant use that flag and iterate them. Other fixes: - dont assume moduleName is always non-NULL - skip thread flush if the buffer is NULL - add aserts to non-sensible events Signed-off-by: Tobi Ajila <[email protected]>
|
Looks like my changes werent published. Ill push them now. |
gacholio
approved these changes
Nov 14, 2024
|
jenkins test sanity xlinux jdk21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other fixes: