Add OpenJ9DiagnosticsMXBean.getDumpOptions #20604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test sanity amac jdk11 |
keithc-ca
requested changes
Nov 19, 2024
jcl/src/jdk.management/share/classes/openj9/lang/management/OpenJ9DiagnosticsMXBean.java
Outdated
Show resolved
Hide resolved
...dk.management/share/classes/openj9/lang/management/internal/OpenJ9DiagnosticsMXBeanImpl.java
Outdated
Show resolved
Hide resolved
pshipton
force-pushed
the
diagbeans
branch
2 times, most recently
from
e9bd592 to
5aeec27
Compare
|
Updated. |
keithc-ca
requested changes
Nov 19, 2024
jcl/src/jdk.management/share/classes/openj9/lang/management/OpenJ9DiagnosticsMXBean.java
Outdated
Show resolved
Hide resolved
jcl/src/jdk.management/share/classes/openj9/lang/management/OpenJ9DiagnosticsMXBean.java
Outdated
Show resolved
Hide resolved
jcl/src/jdk.management/share/classes/openj9/lang/management/OpenJ9DiagnosticsMXBean.java
Outdated
Show resolved
Hide resolved
|
Updated. |
keithc-ca
reviewed
Nov 19, 2024
jcl/src/jdk.management/share/classes/openj9/lang/management/OpenJ9DiagnosticsMXBean.java
Show resolved
Hide resolved
There should be a getter to match the setter. Issue eclipse-openj9#20587 Signed-off-by: Peter Shipton <[email protected]>
keithc-ca
requested changes
Nov 20, 2024
...nctional/JLM_Tests/src/org/openj9/test/java/lang/management/TestOpenJ9DiagnosticsMXBean.java
Outdated
Show resolved
Hide resolved
...nctional/JLM_Tests/src/org/openj9/test/java/lang/management/TestOpenJ9DiagnosticsMXBean.java
Outdated
Show resolved
Hide resolved
|
Updated |
Signed-off-by: Peter Shipton <[email protected]>
|
Jenkins test sanity,extended.functional amac jdk21 |
keithc-ca
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There should be a getter to match the setter.
Issue #20587