Use indent size rather than buffer for printing bytecodes #20667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithc-ca
requested changes
Nov 21, 2024
pshipton
force-pushed
the
sprintfomr
branch
2 times, most recently
from
89ca151 to
dc29b6d
Compare
keithc-ca
reviewed
Nov 21, 2024
keithc-ca
reviewed
Nov 21, 2024
pshipton
force-pushed
the
sprintfomr
branch
2 times, most recently
from
0a6b5eb to
0e54232
Compare
Signed-off-by: Peter Shipton <[email protected]>
pshipton
changed the title
keithc-ca
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
@babsingh Perhaps you could review, and if you're satisfied, merge this concurrently with eclipse-omr/omr#7555?
|
jenkins test sanity amac jdk21 depends eclipse-omr/omr#7555 |
|
jenkins test sanity zlinux jdk11 depends eclipse-omr/omr#7555 |
|
jenkins compile win jdk17 depends eclipse-omr/omr#7555 |
babsingh
approved these changes
Nov 27, 2024
|
Windows machines are offline. Based upon existing testing, I believe that these changes should work fine on Windows as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codependent on eclipse-omr/omr#7555