(0.49) Accelerate StringCoding.hasNegatives on Z #20692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit accelerates the StringCoding.hasNegatives API that is found in Java11+ and is considered and intrinsic candidate. Signed-off-by: Dhruv Chopra <[email protected]>
This commit adds a missing break statement when indicating that StringCoding.hasNegatives API in the optimizer. Signed-off-by: Dhruv Chopra <[email protected]>
This commit simplfies some of the code around and inside the inlineStringCodingHasNegatives evaluator in the z/codegen. The changes are: - Return true unconditionally after inlining StringCoding.hasNegatives - Add doxygen comments for inlineStringCodingHasNegatives - Declare one-time use variables to consts in inlineStringCodingHasNegatives Signed-off-by: Dhruv Chopra <[email protected]>
This commit adds the following improvements to the z/codegen intrinsic evaluator for the StringCoding.hasNegatives() API. - Remove unnecessary doxygen comment - Use shorter sized instructions where possible - Use ARK instead of AGRK for adding 32-bit data to avoid potential bugs - Process 16 chars in residue handling code to save an extra branch instruction - Reuse registers where possible Signed-off-by: Dhruv Chopra <[email protected]>
- Fix a bug where 0 length arrays return an incorrect value - Fix a bug where offsets indicating starting point of 'hasNegatives' comparison are not respected. Signed-off-by: Dhruv Chopra <[email protected]>
dchopra001
changed the title
pshipton
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accelerate StringCoding.hasNegatives() API on s390 platform.
Port of #20574