Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict special handling of MemorySegment methods to only the getters and setters #20696

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Restrict special handling of MemorySegment methods to only the getters and setters #20696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0da8d25
Only set RecognizedMethod info for MemorySegment getters and setters
nbhuiyan Nov 27, 2024
63cae52
Restrict peeking of MemorySegment method callers to only when needed
nbhuiyan Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion runtime/compiler/env/j9method.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4830,7 +4830,8 @@ void TR_ResolvedJ9Method::construct()
}
else if ((classNameLen == 31) && !strncmp(className, "java/lang/foreign/MemorySegment", 31))
{
setRecognizedMethodInfo(TR::java_lang_foreign_MemorySegment_method);
if (nameLen >= 3 && (!strncmp(name, "get", 3) || !strncmp(name, "set", 3)))
setRecognizedMethodInfo(TR::java_lang_foreign_MemorySegment_method);
}
#endif
else if ((classNameLen >= 59 + 3 && classNameLen <= 59 + 7) && !strncmp(className, "java/lang/invoke/ArrayVarHandle$ArrayVarHandleOperations$Op", 59))
Expand Down
2 changes: 1 addition & 1 deletion runtime/compiler/optimizer/J9EstimateCodeSize.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -847,7 +847,7 @@ TR_J9EstimateCodeSize::processBytecodeAndGenerateCFG(TR_CallTarget *calltarget,
if (meth)
{
const char * sig = meth->signature(comp()->trMemory());
if (sig && !strncmp(sig, "java/lang/foreign/MemorySegment", 31))
if (sig && (!strncmp(sig, "java/lang/foreign/MemorySegment.get", 35) || !strncmp(sig, "java/lang/foreign/MemorySegment.set", 35) ))
{
nph.setNeedsPeekingToTrue();
heuristicTrace(tracer(), "Depth %d: invokeinterface call at bc index %d has Signature %s, enabled peeking for caller to fold layout field load necessary for VarHandle operation inlining.", _recursionDepth, i, sig);
Expand Down