(0.49) Add check for JFR enablement #20879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, JFR is enabled by default on all platforms that support it, and it cannot be disabled. We have been using `-XX:+FlightRecorder` to indicate if the JVM should start with recording enabled. This is not consistent with the RI. With this change `-XX:[+|-]FlightRecorder` toggles whether JFR is enabled. By default JFR will remain enabled, but we now have the ability to disable it. `-XX:StartFlightRecording` will be used to indicate that a recording should be begin at startup. Signed-off-by: tajila <[email protected]>
pshipton
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, JFR is enabled by default on all platforms that support it, and it cannot be disabled. We have been using
-XX:+FlightRecorderto indicate if the JVM should start with recording enabled. This is not consistent with the RI.With this change
-XX:[+|-]FlightRecordertoggles whether JFR is enabled. By default JFR will remain enabled, but we now have the ability to disable it.-XX:StartFlightRecordingwill be used to indicate that a recording should be begin at startup.Backport of #20854