Move JFR loadedClassCount to J9JavaVM #20987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JFR loadedClassCount was originally kept tracked in classloader. When the classloader gets unloaded, we will lose the count. Related: eclipse-openj9#20679 Signed-off-by: Gengchen Tuo <[email protected]>
|
@tajila can you please review? |
|
jenkins test sanity.functional alinux64 jdk17 |
keithc-ca
reviewed
Jan 22, 2025
| @@ -2169,7 +2169,7 @@ internalCreateRAMClassDone(J9VMThread *vmThread, J9ClassLoader *classLoader, J9C | |||
| } | |||
|
|
|||
| #if defined(J9VM_OPT_JFR) | |||
| hostClassLoader->loadedClassCount += 1; | |||
| javaVM->loadedClassCount += 1; | |||
There was a problem hiding this comment.
This should be done atomically.
There was a problem hiding this comment.
The calling thread should be holding the classtable mutex so we don't need atomic?
There was a problem hiding this comment.
It seems you're right, however, it would help if this function called out that expectation (like line 759 does for computeVTable().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JFR loadedClassCount was originally kept tracked in classloader. When the classloader gets unloaded, we will lose the count.
Related: #20679