Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug #994 - manualAcks for QoS 2 messages #995

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

lacourte
Copy link

Please make sure that the following boxes are checked before submitting your Pull Request, thank you!

  • [ x] This change is against the develop branch, not master.
  • [x ] You have signed the Eclipse ECA
  • [x ] All of your commits have been signed-off with the correct email address (the same one that you
    used to sign the CLA) Hint: use the -s argument when committing.
  • [ x] If This PR fixes an issue, that you reference the issue below. OR if this is a new issue that
    you are fixing straight away that you add some Description about the bug and how this will fix it.
  • If this is new functionality, You have added the appropriate Unit tests.

This patch fixes bug #994.
The fix only concerns the client v5. The bug actually does not exist in the client v3.
The fix reports the implementation of the feature from the client v3 into the client v5.

@whizyrel
Copy link

whizyrel commented Aug 1, 2024

Hello guys, great job here but this issue is still persistent with v5 1.2.5.
I have read #994, and #1023, it does not happen to have a fix.
I have submitted this issue #1054.

1 similar comment
@whizyrel
Copy link

whizyrel commented Aug 1, 2024

Hello guys, great job here but this issue is still persistent with v5 1.2.5.
I have read #994, and #1023, it does not happen to have a fix.
I have submitted this issue #1054.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants