Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add config support for TCP Bridges #55

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

andreas-ibm
Copy link

This is only barely tested, and not all the configuration settings will be applied by TCPBridges (e.g. the prefixes haven't been implemented and in direction hasn't been implemented.

@icraggs
Copy link
Contributor

icraggs commented Aug 9, 2018

Hi Andreas. Thanks - you need to fix the IP checks before I could merge this:

"The pull request did not pass Eclipse validation.

The following users do not have valid ECAs:
[email protected]

The following users have invalid Signed-off-by footers:
[email protected]"

It's the Eclipse way - for which there are good reasons.

Signed-off-by: Andreas Martens <[email protected]>
@andreas-ibm
Copy link
Author

yeah, saw the failures, took me a while to figure out how to "solve" them.. Think it's all done now?

@icraggs
Copy link
Contributor

icraggs commented Aug 9, 2018

Yep. All good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants