Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the ldap container healthcheck to check if users have been loaded #383

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

markpatton
Copy link
Contributor

You can verify it works by commenting out the ldapadd command.

eclipse-pass.local.yml Outdated Show resolved Hide resolved
@rpoet-jh
Copy link
Contributor

@markpatton looks good. Only other thing I noticed is that I used to see in the ldap logs when the users were created, but I don't see that in the log any longer. However, I'm able to login using staff1, so the users have to be there. Not a big deal, just pointing it out jic.

@markpatton
Copy link
Contributor Author

@rpoet-jh That's probably a side effect of moving init stuff to the healthcheck. I wonder if there is a way to see output from the healthcheck?

@rpoet-jh
Copy link
Contributor

@rpoet-jh That's probably a side effect of moving init stuff to the healthcheck. I wonder if there is a way to see output from the healthcheck?

@markpatton Ah right, because the ldapadd call was in the docker command config, makes sense. I wouldn't worry about it, if there is any issue, the ldap container won't become healthy.

@markpatton markpatton merged commit c23fc30 into main Nov 1, 2024
2 checks passed
@markpatton markpatton deleted the fix-ldap-healthcheck branch November 1, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants