Grant Loader Fibi Migration #117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markpatton
approved these changes
Jun 6, 2024
rpoet-jh
force-pushed
the
russ-688-fibi
branch
2 times, most recently
from
7bb8a7c
to
6748bb9
Compare
rpoet-jh
force-pushed
the
russ-688-fibi
branch
from
6e0fb87
to
e1a51d6
Compare
Because it is in the view sql
And add null test to ingest validation
rpoet-jh
force-pushed
the
russ-688-fibi
branch
from
e1a51d6
to
3e88f95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the JHU grant loader connector to use the new JHU grant database Fibi instead of COEUS.
Fibi is a MySQL database, so there were some dependency changes. I also added h2 for testing so non-mock tests could be added for the grant connector class.
Note the
awardEndDateCLI option date format was changed frommm/dd/yyyytoyyyy-mm-ddto be more consistent with thestartDateTimeCLI option format.