Fix breakage caused by o.e.p.i.publishing.Utils changes

[merks]

eclipse-equinox/p2#550

[merks]

@HannesWell @akurtakov @iloveeclipse

Given the I-build is broken, this, or something like this, needs to be merged sooner rather than later.

[iloveeclipse]

Should the bundle dependency be updated too?

[merks]

I suppose that's a good idea too, yes.

[github-actions]

Test Results

 6 files   -    279   6 suites   - 279   12s ⏱️ - 48m 49s
 4 tests  -  3 577   4 ✅  -  3 501  0 💤  -  76  0 ❌ ±0 
12 runs   - 10 923  12 ✅  - 10 692  0 💤  - 231  0 ❌ ±0 

Results for commit e041547. ± Comparison against base commit f7070db.

This pull request removes 3577 tests.

AllPDETests org.eclipse.pde.core.tests.internal.AllPDECoreTests org.eclipse.pde.core.tests.internal.DependencyManagerTest ‑ testFindRequirementsClosure_importPackage
AllPDETests org.eclipse.pde.core.tests.internal.AllPDECoreTests org.eclipse.pde.core.tests.internal.DependencyManagerTest ‑ testFindRequirementsClosure_includeFragments
AllPDETests org.eclipse.pde.core.tests.internal.AllPDECoreTests org.eclipse.pde.core.tests.internal.DependencyManagerTest ‑ testFindRequirementsClosure_includeFragmentsProvidingPackages
AllPDETests org.eclipse.pde.core.tests.internal.AllPDECoreTests org.eclipse.pde.core.tests.internal.DependencyManagerTest ‑ testFindRequirementsClosure_includeNonTestFragments
AllPDETests org.eclipse.pde.core.tests.internal.AllPDECoreTests org.eclipse.pde.core.tests.internal.DependencyManagerTest ‑ testFindRequirementsClosure_includeOptional
AllPDETests org.eclipse.pde.core.tests.internal.AllPDECoreTests org.eclipse.pde.core.tests.internal.DependencyManagerTest ‑ testFindRequirementsClosure_requireBundle
AllPDETests org.eclipse.pde.core.tests.internal.AllPDECoreTests org.eclipse.pde.core.tests.internal.DependencyManagerTest ‑ testFindRequirementsClosure_requireBundle2
AllPDETests org.eclipse.pde.core.tests.internal.AllPDECoreTests org.eclipse.pde.core.tests.internal.DependencyManagerTest ‑ testFindRequirementsClosure_requireDifferentVersions
AllPDETests org.eclipse.pde.core.tests.internal.AllPDECoreTests org.eclipse.pde.core.tests.internal.DependencyManagerTest ‑ testFindRequirementsClosure_requiredCapability
AllPDETests org.eclipse.pde.core.tests.internal.AllPDECoreTests org.eclipse.pde.core.tests.internal.WorkspaceModelManagerTest ‑ testBundleRootHandling_bundleRootChangedFromDefaultToOthersAndReverse
…

[merks]

@iloveeclipse

I think I cannot change the bound because the I-build is broken so the new p2 thingy isn't available yet. So I can either merge this change without verification or the bound needs to change later after a successful I-build.

What shall it be?

[akurtakov]

Merge and start new I-build. That way there is at least a chance to have it done at once.

[merks]

Started https://ci.eclipse.org/releng/job/Builds/job/I-build-4.34/48/

[HannesWell]

Thank you Ed and sorry for the trouble! One really has to be very careful with P2, even if its internal. :/

I think I cannot change the bound because the I-build is broken so the new p2 thingy isn't available yet. So I can either merge this change without verification or the bound needs to change later after a successful I-build.

Even if the bound is satisfied the change can't succeed with a green verification, because without an I-build the changed method signatures are not available. So it's a chicken-egg problem not solvable with only green builds.
So I agree that doing it at once is the best: Close your eyes and go (to say it with a badly translated German quote).