Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create codeQLworkflow.yml #1239

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Create codeQLworkflow.yml #1239

merged 1 commit into from
Aug 2, 2023

Conversation

jukzi
Copy link
Contributor

@jukzi jukzi commented Aug 1, 2023

@HannesWell
Copy link
Member

If the codeQL workflow would be added to the existing mavenBuild workflow (maybe with an option to disable/enable it), we would probably save a lot of duplication?

@jukzi
Copy link
Contributor Author

jukzi commented Aug 2, 2023

mavenBuild is a matrix of JVM versions, while codeQL is a matrix of programming languages.
mavenBuild is normally scheduled for each PR, codeQL is normally scheduled once a week or commit on master - the results are not shown on the PR but in the security tab.

@laeubi
Copy link
Contributor

laeubi commented Aug 2, 2023

I have ssen CodeQL runs also on PR verification, nerveless it could be an independent workflow that could then be added to the projets CI workflow like the license check. What I'm wondering, why does it need a maven build at all?

@jukzi
Copy link
Contributor Author

jukzi commented Aug 2, 2023

by default it uses autobuild, which does not work for our repos. It needs to be build somehow. I guess it analyses the .class files. It worked with maven. If you have another working solution please do.

@laeubi
Copy link
Contributor

laeubi commented Aug 2, 2023

Your inital description contains:

CodeQL https://codeql.github.com/ can hint to problems in sourcecode

So I somehow assumed it analyzes the source... but if it requires a mavenbuild, maybe one can reuse the results of the regular maven build like it is done with the Junit results?

@jukzi jukzi merged commit 9a4123a into master Aug 2, 2023
2 checks passed
@jukzi jukzi deleted the jukzi-patch-1 branch August 2, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants