-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generated all OSGi Declarative Services component files by PDE-DS/Tycho #2344
base: master
Are you sure you want to change the base?
Generated all OSGi Declarative Services component files by PDE-DS/Tycho #2344
Conversation
99f7c85
to
15a32bb
Compare
This pull request changes some projects for the first time in this development cycle.
An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patch
Further information are available in Common Build Issues - Missing version increments. |
|
||
@Component(service = IContextFunction.class, property = { | ||
"service.context.key=org.eclipse.e4.ui.progress.IProgressService" }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to define a component property type for this @ServiceContectKey(Class)) this will avoid needing to manually set such property
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that would be handy here. Proposed it in
@@ -38,6 +40,7 @@ | |||
|
|||
import org.eclipse.search.internal.core.text.DirtyFileProvider; | |||
|
|||
@Component(service = DirtyFileProvider.class, immediate = false, property = { "weight:Integer=100" }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe replace weight with ServiceRank?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it would have been a good choice when this service was introduced. But now that it is defined as property to sort difference service implementations I would consider this an API and for now I don't want to implement support for both in DirtyFileSearchParticipantServiceTracker
.
Line 36 in 04dc50b
private static final String PROPERTY_WEIGHT = "weight"; //$NON-NLS-1$ |
Remove the now generated OSGi Declarative Services component-xml files from git. Resolve wildcards in Service-Component header.
e089d89
to
b3de554
Compare
Remove the now generated OSGi Declarative Services component-xml files from git.
Resolve wildcards in Service-Component header.
@laeubi do you want to have a look at this as well?