Skip to content

Commit

Permalink
Remove sorting parameter from ConfigurationSessionTestSuite #903
Browse files Browse the repository at this point in the history
The ConfigurationSessionTestSuite sorts the test methods by default. A
field identifies whether sorting is activated, but the field cannot even
be set but is always true. So, this parameterization is completely
obsolete and only introduces unnecessary complexity to the session test
framework.

Contributes to
#903
  • Loading branch information
HeikoKlare committed Jul 4, 2024
1 parent 29d6edf commit 969aac6
Showing 1 changed file with 0 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,9 @@ public class ConfigurationSessionTestSuite extends SessionTestSuite {
private IPath configurationPath = FileSystemHelper.getRandomLocation(FileSystemHelper.getTempDir());
private boolean prime = true;
private boolean readOnly;
// should the test cases be run in alphabetical order?
private boolean shouldSort;

public ConfigurationSessionTestSuite(String pluginId, Class<?> theClass) {
super(pluginId, theClass);
this.shouldSort = true;
}

public ConfigurationSessionTestSuite(String pluginId, String name) {
Expand Down Expand Up @@ -269,11 +266,6 @@ public void run(TestResult result) {
fail(e);
}
}
if (!shouldSort) {
// for shared sessions, we don't control the execution of test cases
super.run(result);
return;
}
// we have to sort the tests cases
Test[] allTests = getTests(true);
// now run the tests in order
Expand Down

0 comments on commit 969aac6

Please sign in to comment.