Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toString() for better resource debugging #1329

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

iloveeclipse
Copy link
Member

See #470

@fedejeanne
Copy link
Contributor

Could the calls to methods like exists() or isSet(int) become a bottleneck or are they mere bitwise comparisons?

@iloveeclipse
Copy link
Member Author

It's toString(), which bottleneck you mean? It's only used while debugging code.

@fedejeanne
Copy link
Contributor

I know, debugging is also a use-case for us developers, that's why I ask. Additionally, one can never completely rule out the possibility that production code is using toString() too (even if it's a bad idea).

Let me rephrase :-)
I've noticed that toString() now call methods as opposed to just reading from fields. I trust they will not (significantly) degrade performance, even when debugging? I can live with a slight performance decrease when debugging if it helps to debug.

Copy link
Contributor

Test Results

   639 files  ±0     639 suites  ±0   38m 50s ⏱️ - 2m 28s
 3 949 tests ±0   3 927 ✅ ±0   22 💤 ±0  0 ❌ ±0 
12 453 runs  ±0  12 292 ✅ ±0  161 💤 ±0  0 ❌ ±0 

Results for commit 0d01b09. ± Comparison against base commit 1012283.

@iloveeclipse
Copy link
Member Author

No, they don't degrade performance in a way anyone would notice that.

@iloveeclipse
Copy link
Member Author

Test failis unrelated.

@iloveeclipse iloveeclipse merged commit 35820b0 into eclipse-platform:master Apr 26, 2024
12 of 16 checks passed
@iloveeclipse iloveeclipse deleted the issue_470 branch April 26, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants