Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(UI): Moderation Request for releases does not show any changes issue fix #2369

Closed

Conversation

keerthi-bl
Copy link
Contributor

Please provide a summary of your changes here.

  • Which issue is this pull request belonging to and how is it solving it? (Refer to issue here)
  • Did you add or update any new dependencies that are required for your change?

Issue:

Closes #2368

Suggest Reviewer

You can suggest reviewers here with an @mention.

How To Test?

Steps :

  1. Create a moderation request of any release
  2. next time onwards keep submit to create a moderation request of the same without any changes
  3. It will keep create the moderation request in old code
  4. This issue is fixed with this Validation PR
  5. It should not allow if no changes made while creating a moderation request of any release.

Checklist

Must:

  • All related issues are referenced in commit messages and in PR

@ag4ums ag4ums added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for labels Mar 19, 2024
@nikkuma7
Copy link
Contributor

I followed the above test steps, but MR is creating.

@keerthi-bl keerthi-bl force-pushed the fix/emptymoderationreqissuefix branch from 553e005 to 2f05894 Compare March 28, 2024 06:55
@GMishx
Copy link
Member

GMishx commented Aug 16, 2024

@keerthi-bl this PR can be closed as the changes are in only in frontend which does not exist anymore?

@keerthi-bl
Copy link
Contributor Author

Yes @GMishx . We can close this issue and PR here. We may also need to open this issue in new UI repo as well.

@GMishx
Copy link
Member

GMishx commented Aug 16, 2024

Can you please open the issue in https://github.com/eclipse-sw360/sw360-frontend/ for the same and then close this PR @keerthi-bl then?

@keerthi-bl
Copy link
Contributor Author

Closing this PR, issue has been created at the front-end for the same with ref : eclipse-sw360/sw360-frontend#310

FYR : @GMishx :

@keerthi-bl keerthi-bl closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs clarification needs code review needs general test This is general testing, meaning that there is no org specific issue to check for
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moderation Request does not show any changes - Releases
4 participants