Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rest) : Export Project Create Clearing Request #2493

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

keerthi-bl
Copy link
Contributor

Description

Rest end point forExport Project Create Clearing Request

How to reproduce

Closes : #2461

This PR should be merged after #2442

@rudra-superrr rudra-superrr added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for labels Jul 4, 2024
@nikkuma7
Copy link
Contributor

Test successful.

Uploading image.png…

@rudra-superrr rudra-superrr added has merge conflicts and removed needs general test This is general testing, meaning that there is no org specific issue to check for labels Sep 4, 2024
@GMishx
Copy link
Member

GMishx commented Sep 6, 2024

@keerthi-bl please rebase with latest main

@keerthi-bl keerthi-bl force-pushed the feat/exportCreateProjClrngReport branch from 5659e13 to 89812be Compare October 7, 2024 06:06
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase with latest main

Comment on lines -144 to +139
import jakarta.servlet.http.HttpServletRequest;
import jakarta.servlet.http.HttpServletResponse;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use jakarta not javax


import javax.servlet.http.HttpServletRequest;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import javax.servlet.http.HttpServletRequest;
import jakarta.servlet.http.HttpServletRequest;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(Rest) : Rest end point for exporting Create project Clearing report.
4 participants