Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rest): Add additional fields in get clearingrequest endpoints. #2616

Conversation

akshitjoshii
Copy link
Contributor

@akshitjoshii akshitjoshii commented Sep 17, 2024

Extra fields needed for get clearing request endpoints are added in the response.

Closes : #2500, #2499
Endpoints where new fields are added :

http://localhost:8080/resource/api/clearingrequests
http://localhost:8080/resource/api/clearingrequest/byId

image

@akshitjoshii akshitjoshii force-pushed the feat/add-additional-fields-CR-endpoint branch from a13d435 to fc00aae Compare September 18, 2024 07:54
@akshitjoshii akshitjoshii force-pushed the feat/add-additional-fields-CR-endpoint branch from fc00aae to 90ad3ea Compare September 18, 2024 07:56
@GMishx GMishx added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for labels Sep 18, 2024
@smrutis1 smrutis1 self-requested a review September 25, 2024 08:11
@amritkv
Copy link

amritkv commented Sep 27, 2024

Hey @akshitjoshii @GMishx !
Tested the PR and response looks good to me. 👍🏻

@GMishx GMishx removed the needs general test This is general testing, meaning that there is no org specific issue to check for label Sep 27, 2024
Copy link
Contributor

@smrutis1 smrutis1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me

@smrutis1 smrutis1 merged commit da45600 into eclipse-sw360:main Sep 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need extra fields in GET call to /clearingrequests rest api
4 participants