Document naming conventions & Naming alignment #368
Conversation
jfaltermeier
force-pushed
the
jf/rename
branch
2 times, most recently
from
d87764e
to
45dd773
Compare
jfaltermeier
changed the title
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "name": "theiacloud-monitor", | |||
| "name": "theia-cloud-monitor", | |||
There was a problem hiding this comment.
Do we need to take care of something here regarding the release to npm?
There was a problem hiding this comment.
The npm package is already published under a name following the conventions: https://www.npmjs.com/package/@eclipse-theiacloud/monitor-theia.
This one here is the vsix, which hasn’t been published to open-vsx yet, so we should be fine.
There was a problem hiding this comment.
Hi @jfaltermeier, thanks for aligning the naming and the documentation. This saves a lot of wondering what is the correct spelling ✨
The changes already look pretty good to me. I have two remarks inline. One tiny suggestion and one hint regarding consistency in Kubernetes label key naming. Please have a look.
...ava/org/eclipse/theia/cloud/operator/handler/appdef/EagerStartAppDefinitionAddedHandler.java
Show resolved
Hide resolved
Contributed on behalf of STMicroelectronics
jfaltermeier
force-pushed
the
jf/rename
branch
from
45dd773
to
11f374c
Compare
Co-authored-by: Simon Graband <[email protected]>
Co-authored-by: Lucas Koehler <[email protected]>
Contributed on behalf of STMicroelectronics
|
We have to use I addressed this + the comments above now |
Please check the
Naming.mdfirst https://github.com/eclipse-theia/theia-cloud/pull/368/files#diff-458dcaeb7b373b080fb85240d56af356cc0cbc6d054f90fb92ef87dcf4748cb5Let me know what you think about the changes.
Contributed on behalf of STMicroelectronics
Helm Chart Changes
eclipse-theia/theia-cloud-helm#78